ci: fix `airbyte-ci` installation in connector tests flows by aaronsteers · Pull Request #528 · airbytehq/airbyte-python-cdk

Aaron ("AJ") Steers (aaronsteers) · 2025-05-01T19:56:29Z

Switch to binary install of airbyte-ci. Required bumping ubuntu to 24, since 22 is not compatible with the binary.

Summary by CodeRabbit

Chores
- Updated the testing workflow to use Ubuntu 24.04 for improved environment consistency.
- Adjusted the workflow to use an updated installation command during connector tests.

Copilot

Pull Request Overview

This PR fixes the installation of airbyte-ci in connector tests by switching to the binary install, which requires updating the Ubuntu version from 22.04 to 24.04 and modifying the installation command.

Updated Ubuntu version and CI commands in connector tests workflow
Updated make target from airbyte-ci-dev.install to airbyte-ci.install in the workflow
Added a dummy comment in the logger module (likely unintended)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
airbyte_cdk/logger.py	Contains a dummy comment that appears unnecessary for production code
.github/workflows/connector-tests.yml	Updated Ubuntu version and modified CI installation command

Comments suppressed due to low confidence (1)

.github/workflows/connector-tests.yml:156

Verify that updating the make target to 'tools.airbyte-ci.install' aligns with the binary installation requirements and that all relevant references to the previous target are updated.

make tools.airbyte-ci.install

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

coderabbitai · 2025-05-01T20:19:47Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request updates the "Test Connectors" GitHub Actions workflow by changing the runner environment from Ubuntu 22.04 to Ubuntu 24.04 for the cdk_changes and connectors_ci jobs. Additionally, the Makefile target used in the connectors_ci job is updated from tools.airbyte-ci-dev.install to tools.airbyte-ci.install. No changes were made to the logic, control flow, or error handling.

Changes

File(s)	Change Summary
.github/workflows/connector-tests.yml	Updated runner environment from Ubuntu 22.04 to 24.04 for `cdk_changes` and `connectors_ci`. Changed Makefile target in `connectors_ci` from `tools.airbyte-ci-dev.install` to `tools.airbyte-ci.install`.

Possibly related PRs

ci: use binary of airbyte-ci instead of dev version that requires python10 #208: Also updates .github/workflows/connector-tests.yml to change the Makefile target for Airbyte CI tools installation, showing a related CI installation update.
ci: run airbyte connector tests from master branch #99: Modifies the same workflow file, focusing on branch references, connector filtering, and job cancellation logic, which is related in context but distinct in scope.

Would you like to see a comparison diagram of the workflow before and after these changes, or does this summary suffice for your review, wdyt?

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce2a7bb and f6b2bcb.

📒 Files selected for processing (1)

.github/workflows/connector-tests.yml (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

David Gold (dbgold17)

lgtm if it works!

Aaron ("AJ") Steers (aaronsteers) added 4 commits May 1, 2025 12:56

try binary install

c77de10

dummy change

da1521c

bump to newer ubuntu

ed012bc

try uv-based install

768fff2

Aaron ("AJ") Steers (aaronsteers) changed the title ~~try binary install~~ ci: fix airbyte-ci installation in connector tests flows May 1, 2025

move back to binary install

b5461af

github-actions bot added the ci label May 1, 2025

Aaron ("AJ") Steers (aaronsteers) marked this pull request as ready for review May 1, 2025 20:18

Copilot AI review requested due to automatic review settings May 1, 2025 20:18

Copilot AI reviewed May 1, 2025

View reviewed changes

Comment thread airbyte_cdk/logger.py Outdated

revert dummy commit

f6b2bcb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

David Gold (dbgold17) self-requested a review May 1, 2025 20:21

David Gold (dbgold17) approved these changes May 1, 2025

View reviewed changes

Aaron ("AJ") Steers (aaronsteers) merged commit 99327c2 into main May 1, 2025
21 of 22 checks passed

Aaron ("AJ") Steers (aaronsteers) deleted the aj/fix/ci/connector-test-airbyte-ci-install branch May 1, 2025 20:21

coderabbitai bot approved these changes May 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: fix `airbyte-ci` installation in connector tests flows#528

ci: fix `airbyte-ci` installation in connector tests flows#528
Aaron ("AJ") Steers (aaronsteers) merged 6 commits intomainfrom
aj/fix/ci/connector-test-airbyte-ci-install

Aaron ("AJ") Steers (aaronsteers) commented May 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai bot commented May 1, 2025 •

edited

Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

David Gold (dbgold17) left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Aaron ("AJ") Steers (aaronsteers) commented May 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

coderabbitai bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

David Gold (dbgold17) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aaron ("AJ") Steers (aaronsteers) commented May 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)